Added a bundle deprecation notice in other articles #8434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Sep 28, 2017
|
👎 This article is exactly explaining how to override stuff without bundle inheritance. So this article becomes more important now inheritance is deprecated. It makes no sense to add this caution there imo. |
|
This article may not be about bundle inheritance, but it mentions that four times:
|
|
Then, instead of adding this confusing warning, I think we should remove the references to the other article in this article. |
xabbuh
reviewed
Oct 10, 2017
bundles/override.rst
Outdated
| @@ -5,7 +5,8 @@ How to Override any Part of a Bundle | |||
| ==================================== | |||
|
|
|||
| This document is a quick reference for how to override different parts of | |||
| third-party bundles. | |||
| third-party bundleswithout using :doc:`/bundles/inheritance`, which is deprecated | |||
There was a problem hiding this comment.
missing space between "bundles" and "without"
xabbuh
approved these changes
Oct 10, 2017
wouterj
approved these changes
Oct 10, 2017
|
Thank you Javier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #8389 but for another article.